Repository navigation
fix(sdk): spell the facade REES46, allow empty syncs, fix the attribution example - #18
Merged
Merged
Conversation
The wrapper rejected an empty list with an ArgumentError, so an emptied cart could not be reported from Flutter at all. The native SDKs deliberately do the opposite — Android's `putEmptyItemsIfNone` always sends the list — so the check contradicted the platform instead of guarding it.
…r in The attribution examples used a recommender block as the source, including as the stored one. A stored source describes where the user arrived from — a bulk push, a chain — and the values come from the link that opened the app.
The public entry point carried the brand as `Rees46`; it is spelled REES46. Renames `Rees46`, `Rees46Config`, `Rees46Error` and `Rees46SdkFactory` along with the doc comments and the pigeon-generated header. BREAKING CHANGE: `Rees46` and friends are now `REES46`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REES46— the only correct spelling of the name.syncCartandsyncFavoritesaccept an empty collection: the natives already senditems: [], the Dart guard was rejecting a legitimate emptied cart.